[can be closed] Test Adapter FuelPriceMonitor Austria v0.2.x

[jackblackson]

Hallo!

Kann es sein, dass hier aktuell die API nicht mehr die richtigen Werte liefert? Bei mir kommt seit Tagen der selbe Preis über die API - wird auch aktualisiert - aber der Wert ist immer der selbe.

Wenn ich es mit den Werten auf https://www.spritpreisrechner.at/ vergleiche sollte der Wert auch höher sein.

[Negalein]

@jackblackson sagte in [can be closed] Test Adapter FuelPriceMonitor Austria v0.2.x:

Kann es sein, dass hier aktuell die API nicht mehr die richtigen Werte liefert?

bei mir passt alles.
Adapter schon neu gestartet?

[jackblackson]

@negalein Ja, schon versucht. Hab auch mal auf debug umgestellt, da kommen keine Fehler, aber die Werte die hier in den JSON stehen machen so keinen Sinn. Ich erhalte eine Tankstelle auf Platz 1, die laut Website aber diesen Preis nicht hat - als gäbe es hier beim Abruf über die API noch eine Leiche, die auf der Website aber nicht besteht.

[{"id":1474169,"name":"eni","location":{"address":"Rheinstrasse 4","postalCode":"6900","city":"Bregenz","latitude":47.4985,"longitude":9.73258},"contact":{"telephone":"0557443760","fax":"05574437604"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"00:00","to":"00:00"},{"day":"DI","label":"Dienstag","order":2,"from":"00:00","to":"00:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"00:00","to":"00:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"00:00","to":"00:00"},{"day":"FR","label":"Freitag","order":5,"from":"00:00","to":"00:00"},{"day":"SA","label":"Samstag","order":6,"from":"00:00","to":"00:00"},{"day":"SO","label":"Sonntag","order":7,"from":"00:00","to":"00:00"},{"day":"FE","label":"Feiertag","order":8,"from":"00:00","to":"00:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true,"others":"AMEX,Maestro,Diners Club,DKV,GUTS,LOGP,MasterCard,Routex,euroShell Card,UTA,VISA"},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":1,"open":false,"distance":2.068175657512824,"prices":[{"fuelType":"SUP","amount":1.719,"label":"Super 95"}]},{"id":1469666,"name":"BayWa Tankstelle","location":{"address":"Scheibenstraße 2","postalCode":"6923","city":"Lauterach","latitude":47.46296,"longitude":9.72747},"contact":{"telephone":"05574 / 70060-611","fax":"05574 / 70060-104","mail":"gerd.nussbaumer@baywa.at","website":"http://www.baywa.at"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"00:00","to":"24:00"},{"day":"DI","label":"Dienstag","order":2,"from":"00:00","to":"24:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"00:00","to":"24:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"00:00","to":"24:00"},{"day":"FR","label":"Freitag","order":5,"from":"00:00","to":"24:00"},{"day":"SA","label":"Samstag","order":6,"from":"00:00","to":"24:00"},{"day":"SO","label":"Sonntag","order":7,"from":"00:00","to":"24:00"},{"day":"FE","label":"Feiertag","order":8,"from":"00:00","to":"24:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":true},"paymentMethods":{"cash":false,"debitCard":true,"creditCard":true,"others":"DKV, UTA, AP-Card"},"paymentArrangements":{"cooperative":false,"clubCard":false,"accessMod":"BAYWA SERVICEKARTE PLUS, Lagerhaus Card, Genol Card,"},"position":2,"open":true,"distance":1.9060828803924545,"prices":[{"fuelType":"SUP","amount":1.783,"label":"Super 95"}]},{"id":4171,"name":"Disk","location":{"address":"Bundesstraße 97","postalCode":"6923","city":"Lauterach","latitude":47.4702303,"longitude":9.7287983},"contact":{"telephone":"435022776923","fax":"435022774923","mail":"info@gutmann.cc","website":"https://www.gutmann.cc/mobilitaet/tankstellen/?utm_source=spr&utm_medium=referral&utm_campaign=spr-standorte&utm_id=spr-standorte&utm_content=spr-standorte-diverse"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"06:00","to":"22:00"},{"day":"DI","label":"Dienstag","order":2,"from":"06:00","to":"22:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"06:00","to":"22:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"06:00","to":"22:00"},{"day":"FR","label":"Freitag","order":5,"from":"06:00","to":"22:00"},{"day":"SA","label":"Samstag","order":6,"from":"06:00","to":"22:00"},{"day":"SO","label":"Sonntag","order":7,"from":"07:00","to":"21:00"},{"day":"FE","label":"Feiertag","order":8,"from":"07:00","to":"21:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true,"others":"Gutmann-Card"},"paymentArrangements":{"cooperative":false,"clubCard":false},"otherServiceOffers":"Shop","position":3,"open":true,"distance":1.091120393417817,"prices":[{"fuelType":"SUP","amount":1.809,"label":"Super 95"}]},{"id":1129869,"name":"Diskont Tankstelle","location":{"address":"Rauhholzstraße 29 (\"Hofer Parkplatz\")","postalCode":"6971","city":"Hard","latitude":47.487896,"longitude":9.702448},"contact":{"mail":"info@gutmann.cc","website":"http://gutmann.cc"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"06:00","to":"22:00"},{"day":"DI","label":"Dienstag","order":2,"from":"06:00","to":"22:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"06:00","to":"22:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"06:00","to":"22:00"},{"day":"FR","label":"Freitag","order":5,"from":"06:00","to":"22:00"},{"day":"SA","label":"Samstag","order":6,"from":"06:00","to":"22:00"},{"day":"SO","label":"Sonntag","order":7,"from":"06:00","to":"22:00"},{"day":"FE","label":"Feiertag","order":8,"from":"06:00","to":"22:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":true},"paymentMethods":{"cash":false,"debitCard":true,"creditCard":true,"others":"AP Karte"},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":4,"open":true,"distance":2.2513235064999013,"prices":[{"fuelType":"SUP","amount":1.809,"label":"Super 95"}]},{"id":449657,"name":"Shell Austria","location":{"address":"RHEINSTRASSE 88","postalCode":"6900","city":"BREGENZ","latitude":47.49363,"longitude":9.71095},"contact":{"telephone":"0557471770"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"00:00","to":"24:00"},{"day":"DI","label":"Dienstag","order":2,"from":"00:00","to":"24:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"00:00","to":"24:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"00:00","to":"24:00"},{"day":"FR","label":"Freitag","order":5,"from":"00:00","to":"24:00"},{"day":"SA","label":"Samstag","order":6,"from":"00:00","to":"24:00"},{"day":"SO","label":"Sonntag","order":7,"from":"00:00","to":"24:00"},{"day":"FE","label":"Feiertag","order":8,"from":"00:00","to":"24:00"}],"offerInformation":{"service":false,"selfService":false,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":5,"open":true,"distance":2.0868478561033355,"prices":[{"fuelType":"SUP","amount":1.819,"label":"Super 95"}]},{"id":1474165,"name":"eni","location":{"address":"Bundesstrasse 18","postalCode":"6923","city":"Lauterach","latitude":47.4821512,"longitude":9.73155},"contact":{"telephone":"0557471829","fax":"05574718294"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"06:30","to":"21:00"},{"day":"DI","label":"Dienstag","order":2,"from":"06:30","to":"21:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"06:30","to":"21:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"06:30","to":"21:00"},{"day":"FR","label":"Freitag","order":5,"from":"06:30","to":"21:00"},{"day":"SA","label":"Samstag","order":6,"from":"07:00","to":"21:00"},{"day":"SO","label":"Sonntag","order":7,"from":"08:00","to":"21:00"},{"day":"FE","label":"Feiertag","order":8,"from":"08:00","to":"21:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true,"others":"AMEX,Maestro,Diners Club,DKV,GUTS,LOGP,MasterCard,Routex,euroShell Card,UTA,VISA"},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":6,"open":true,"distance":0.26631604638965894,"prices":[]},{"id":1354863,"name":"OMV - Bregenz Arlbergstraße 135","location":{"address":"Arlbergstrasse 135","postalCode":"6900","city":"Bregenz","latitude":47.48778,"longitude":9.73324},"contact":{"telephone":"557471115","fax":"55747111513","mail":"retail.at.6521@omv.com","website":"www.omv.com"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"00:00","to":"24:00"},{"day":"DI","label":"Dienstag","order":2,"from":"00:00","to":"24:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"00:00","to":"24:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"00:00","to":"24:00"},{"day":"FR","label":"Freitag","order":5,"from":"00:00","to":"24:00"},{"day":"SA","label":"Samstag","order":6,"from":"00:00","to":"24:00"},{"day":"SO","label":"Sonntag","order":7,"from":"00:00","to":"24:00"},{"day":"FE","label":"Feiertag","order":8,"from":"00:00","to":"24:00"}],"offerInformation":{"service":true,"selfService":true,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true,"others":"UTA, DKV, OMV ROUTEX, EUROTRAFIC, MASTERCARD, MAESTRO, ROUTEX, DINERS, VISA, AMEX, OMV STATIONSKARTE"},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":7,"open":true,"distance":0.899565079643569,"prices":[]},{"id":1474173,"name":"eni","location":{"address":"Achstrasse 39","postalCode":"6922","city":"Wolfurt","latitude":47.48154,"longitude":9.74613},"contact":{"telephone":"0557472154","fax":"05574721544"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"06:00","to":"22:00"},{"day":"DI","label":"Dienstag","order":2,"from":"06:00","to":"22:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"06:00","to":"22:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"06:00","to":"22:00"},{"day":"FR","label":"Freitag","order":5,"from":"06:00","to":"22:00"},{"day":"SA","label":"Samstag","order":6,"from":"06:00","to":"22:00"},{"day":"SO","label":"Sonntag","order":7,"from":"07:00","to":"22:00"},{"day":"FE","label":"Feiertag","order":8,"from":"07:00","to":"22:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true,"others":"AMEX,Maestro,Diners Club,DKV,GUTS,LOGP,MasterCard,Routex,euroShell Card,UTA,VISA"},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":8,"open":true,"distance":1.225562144445952,"prices":[]},{"id":1474106,"name":"eni","location":{"address":"Arlbergstrasse 56","postalCode":"6900","city":"Bregenz-Rieden","latitude":47.495268,"longitude":9.733599},"contact":{"telephone":"0557444231","fax":"0557444231"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"06:00","to":"22:00"},{"day":"DI","label":"Dienstag","order":2,"from":"06:00","to":"22:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"06:00","to":"22:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"06:00","to":"22:00"},{"day":"FR","label":"Freitag","order":5,"from":"06:00","to":"22:00"},{"day":"SA","label":"Samstag","order":6,"from":"06:00","to":"22:00"},{"day":"SO","label":"Sonntag","order":7,"from":"06:00","to":"22:00"},{"day":"FE","label":"Feiertag","order":8,"from":"06:00","to":"22:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true,"others":"AMEX,Maestro,Diners Club,DKV,GUTS,LOGP,MasterCard,Routex,euroShell Card,UTA,VISA"},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":9,"open":true,"distance":1.7207590901148748,"prices":[]},{"id":1474108,"name":"eni","location":{"address":"Rheinstrasse 20","postalCode":"6971","city":"Bregenz-Hard","latitude":47.488611,"longitude":9.702186},"contact":{"telephone":"0557472424","fax":"05574724244"},"openingHours":[{"day":"MO","label":"Montag","order":1,"from":"00:00","to":"24:00"},{"day":"DI","label":"Dienstag","order":2,"from":"00:00","to":"24:00"},{"day":"MI","label":"Mittwoch","order":3,"from":"00:00","to":"24:00"},{"day":"DO","label":"Donnerstag","order":4,"from":"00:00","to":"24:00"},{"day":"FR","label":"Freitag","order":5,"from":"00:00","to":"24:00"},{"day":"SA","label":"Samstag","order":6,"from":"00:00","to":"24:00"},{"day":"SO","label":"Sonntag","order":7,"from":"00:00","to":"24:00"},{"day":"FE","label":"Feiertag","order":8,"from":"00:00","to":"24:00"}],"offerInformation":{"service":false,"selfService":true,"unattended":false},"paymentMethods":{"cash":true,"debitCard":true,"creditCard":true,"others":"AMEX,Maestro,Diners Club,DKV,GUTS,LOGP,MasterCard,Routex,euroShell Card,UTA,VISA"},"paymentArrangements":{"cooperative":false,"clubCard":false},"position":10,"open":true,"distance":2.3014557191511678,"prices":[]}]

Diesen Eintrag auf Platz 1 finde ich nicht im Web:

Wenn ich den im Debug Log angezeigten Link nehme und das JSON manuell abrufe erhalte ich das selbe (falsche) Ergebnis.

[Negalein]

@jackblackson sagte in [can be closed] Test Adapter FuelPriceMonitor Austria v0.2.x:

Wenn ich den im Debug Log angezeigten Link nehme und das JSON manuell abrufe erhalte ich das selbe (falsche) Ergebnis.

zeig mal den Link

[jackblackson]

https://api.e-control.at/sprit/1.0/search/gas-stations/by-address?latitude=47.48&longitude=9.73&fuelType=SUP&includeClosed=true

[Negalein]

@jackblackson sagte in [can be closed] Test Adapter FuelPriceMonitor Austria v0.2.x:

https://api.e-control.at/sprit/1.0/search/gas-stations/by-address?latitude=47.48&longitude=9.73&fuelType=SUP&includeClosed=true

mach beim Adapter ein Issue! Eventuell findet @HGlab etwas.
https://github.com/HGlab01/ioBroker.fuelpricemonitor/issues

[tritor]

Hallo,

ich verwende den FuelPriceMonitor Austria und bekomme soweit die 5 Preise aus den 10 Tankstellen in der Nähe.

Nun würde ich gerne eine WhatsApp absetzen mit dem Kontent:
"Aktueller Dieselpreis der Tankstelle NAME, in 1234 ORT ist: € 1,993"

Der Adapter liefert für die 10 Tankstellen IDs je ID ein Ranking womit man sehen kann welche die günstigste ist, die mit #1 natürlich.

Aber wie frage ich das am effizientesten in Blockly ab?

Was ich bereits habe:

• Als Trigger: jede Änderung von einem der 10 RankingDPs
• Eine Variable die dann den MessageText enthält
• Abfrage ob der Ranking DP für die ID 665614 = 1
• Wenn ja, dann die Variable AktuellgünstigeTankstelle mit dem Messagetext füllen
• dann die WhatsApp senden
  

Dann nach und nach alle Ranking-DP für alle weitern IDs abklappern und diese eben auf 1 prüfen.

Ist ziemlich umständlich und ich bin mir sicher, das geht eleganter.
Bin für jeden Tipp dankbar.

Grüße

[HGlab]

@tritor
Vielleicht hab ich dein Problem nicht ganz verstanden, aber die günstigste findet man doch immer unter
fuelpricemonitor.0.[DEIN_ORT].0.prices.0.amount
Da muss man nichts durchsuchen

[tritor]

@hglab

Diesen Datenpunkt kann ich nicht finden:

Wie komme ich zu dem? In den Adaptereinstellungen verwende ich nur die default Home Einstallungen und keine weiteren Locations.

[Negalein]

@tritor sagte in [can be closed] Test Adapter FuelPriceMonitor Austria v0.2.x:

Wie komme ich zu dem? In den Adaptereinstellungen verwende ich nur die default Home Einstallungen und keine weiteren Locations.

schaut bei mir so aus.

Nimm in den Adapter-Einstellungen mal das Use ID for sort raus.

[tritor]

@negalein
Das war es, danke

[tritor]

@negalein
noch 2 Topics:

Visualisierung:
für die Visualisierung mit Einblendung von Logos habe ich im Moment alle Logos übereinendergelegt und über Sichtbarkeit über die jeweiligen Tankstellennamen gesteuert.

Gibt es da eventuell was smarteres, da ich 8 Tankstellenlogos für jede Tankstelle die ich darstelle übereinnanderlegen muß.

Logging:
Nachdem nun unter ID 0 immer wieder eine andere Tankstelle die günstigste sein kann, macht das Protokollieren nur bedingt Sinn, da. ich z.b. die Preisentwicklung einer Tankstelle aufzeichnen möchte.

Ich nehme an das dies am Besten mit einer 2. Instanz des Fuelmonitors gemacht wird und da eben die Tankstellen ID zum sortieren heranziehen, dann wird unter Tankstellen-ID 1234546 immer dieselbe Tankstelle mit Daten versorgt.

[liv-in-sky]

@hglab hi - habe folgendes beobachtet - passiert zu den definierten zeiten deines adapters - ist das normal

cpu % peaks - über 2 stunden - alle 15 min

normal sieht es bei mir über die 2 std so aus - adapter disabled:

[HGlab]

@liv-in-sky
Hi, nein aus meiner Sicht ist das nicht normal. Vor allem weil der Adapter normalerweise bei 1 bis 5 Orten bzw. Sprittypen nur ein paar Sekunden läuft. Bei mir sind es 6 Sekunden.

2023-02-15 00:11:26.517 - info: fuelpricemonitor.0 (28996) starting. Version 0.3.4 in /opt/iobroker/node_modules/iobroker.fuelpricemonitor, node: v16.19.0, js-controller: 4.0.24
2023-02-15 00:11:26.539 - info: fuelpricemonitor.0 (28996) Started with JSON-Explorer version 0.1.10
2023-02-15 00:11:31.676 - info: fuelpricemonitor.0 (28996) Terminated (NO_ERROR): Without reason
2023-02-15 00:11:32.195 - info: fuelpricemonitor.0 (28996) cleaned everything up...

In den 6 Sekunden kann es aber schon zu einem CPU-Peak kommen, da der Adapter gestartet wird und dabei sicher kurz CPU zieht.

[liv-in-sky]

@hglab

um die länge geht es mir nicht - das ist bei diesem graphen und wie ich die daten bekomme nicht wirklich ersichtlich - es ist der peak von 90% - ich habe einige andere adapter, die zeitgesteuert sind - der peak ist nirgends so hoch - nicht mal bei backitup

hier mal ein vergleich

erster: fuelprice
2. backitup
3 :ical
4: unifi
5: javascript (mit vielen vielen scripten)

nur fuelprice schafft die 100% auslastung

[HGlab]

@liv-in-sky
Ich kann nur etwas zu backitup und javascript sagen.
Da vergleichst du Äpfel und Birnen! Beide laufen durchgehend und nicht als CronJob, damit haben diese beiden Adapter keine Adapter-Start / Adapter Stop Peaks weil sie nicht gestartet und gestoppt werden.

Nur Adapter, die diese Uhr

haben sind CronJobs.

Relevant ist auch generell nicht die Max-CPU sondern die CPU-Zeit und bei dem Fuelpricemonitor ist die CPU Zeit minimal, da der Adapter ca. 0,4% der Zeit aktiv ist (alle 20 Minuten für 5 Sekunden). Auch wenn er die ganzen 5 Sekunden 100% hätte (was er bei weitem nicht hat) wäre das immer noch sehr wenig CPU Zeit über den ganzen Tag verteilt.

Ein fairer Vergleich wäre zB mit daswetter

Aber generell ist es absolut nichts schlechtes, wenn ein Adapter für eine oder wenige Sekunden 100% CPU konsumiert. Bedeutet nur, dass er rasch und ohne weitere Bottlenecks hochstarten kann.

[liv-in-sky]

@hglab dann ist ja alles gut - danke